Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 04/10/2012 18:19, Luiz Capitulino ha scritto: -int unix_listen_opts(QemuOpts *opts) +int unix_listen_opts(QemuOpts *opts, Error **errp) { -fprintf(stderr, unix sockets are not available on windows\n); +error_setg(errp, unix

Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions

2012-10-04 Thread Luiz Capitulino
On Wed, 3 Oct 2012 16:36:49 +0200 Paolo Bonzini pbonz...@redhat.com wrote: This lets me adjust the clients to do proper error propagation first, thus avoiding temporary regressions in the quality of the error messages. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- nbd.c

Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 18:19, Luiz Capitulino ha scritto: -int unix_listen_opts(QemuOpts *opts) +int unix_listen_opts(QemuOpts *opts, Error **errp) { -fprintf(stderr, unix sockets are not available on windows\n); +error_setg(errp, unix sockets are not available on windows); As we've

Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions

2012-10-04 Thread Luiz Capitulino
On Thu, 04 Oct 2012 18:39:06 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 04/10/2012 18:19, Luiz Capitulino ha scritto: -int unix_listen_opts(QemuOpts *opts) +int unix_listen_opts(QemuOpts *opts, Error **errp) { -fprintf(stderr, unix sockets are not available on

[Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions

2012-10-03 Thread Paolo Bonzini
This lets me adjust the clients to do proper error propagation first, thus avoiding temporary regressions in the quality of the error messages. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- nbd.c | 4 ++-- qemu-char.c | 6 +++--- qemu-sockets.c | 30