Re: [Qemu-devel] [PATCH 02/19] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan

2018-05-11 Thread Richard Henderson
On 05/11/2018 08:06 AM, Alex Bennée wrote: > but...but... >>> -float16 float16_maybe_silence_nan(float16 a_, float_status *status) >>> + >>> +float16 float16_maybe_silence_nan(float16 a, float_status *status) >>> { >>> +if (float16_is_signaling_nan(a, status)) { >>> +float16_silence_na

Re: [Qemu-devel] [PATCH 02/19] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan

2018-05-11 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> The new function assumes that the input is an SNaN and >> does not double-check. >> >> Signed-off-by: Richard Henderson > > Reviewed-by: Alex Bennée but...but... >> -float16 float16_maybe_silence_nan(float16 a_, float_status *status) >> +

Re: [Qemu-devel] [PATCH 02/19] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan

2018-05-11 Thread Alex Bennée
Richard Henderson writes: > The new function assumes that the input is an SNaN and > does not double-check. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > fpu/softfloat-specialize.h | 174 + > include/fpu/softfloat.h| 5 ++ >

[Qemu-devel] [PATCH 02/19] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan

2018-05-10 Thread Richard Henderson
The new function assumes that the input is an SNaN and does not double-check. Signed-off-by: Richard Henderson --- fpu/softfloat-specialize.h | 174 + include/fpu/softfloat.h| 5 ++ 2 files changed, 123 insertions(+), 56 deletions(-) diff --git a/fpu/so