On Mon, 02/10 09:24, Paolo Bonzini wrote:
> Il 10/02/2014 08:38, Fam Zheng ha scritto:
> >>> if (s->client.is_unix) {
> >>> -sock = unix_socket_outgoing(qemu_opt_get(s->socket_opts,
> >>> "path"));
> >>> +sock = unix_connect(qemu_opt_get(s->socket_opts, "path"), errp);
> >Why
Il 10/02/2014 08:38, Fam Zheng ha scritto:
> if (s->client.is_unix) {
> -sock = unix_socket_outgoing(qemu_opt_get(s->socket_opts, "path"));
> +sock = unix_connect(qemu_opt_get(s->socket_opts, "path"), errp);
Why not use unix_connect_opts like below?
Right!
> } else
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Before:
> $ ./qemu-io-old
> qemu-io-old> open -r -o file.driver=nbd
> one of path and host must be specified.
> qemu-io-old: can't open device (null): Could not open image: Invalid
> argument
> $ ./qemu-io-old
> qemu-io-old> open
Before:
$ ./qemu-io-old
qemu-io-old> open -r -o file.driver=nbd
one of path and host must be specified.
qemu-io-old: can't open device (null): Could not open image: Invalid
argument
$ ./qemu-io-old
qemu-io-old> open -r -o file.driver=nbd,file.host=foo,file.path=bar
path
