Re: [Qemu-devel] [PATCH 02/28] target/riscv: Convert RVXI branch insns to decodetree

2018-10-12 Thread Richard Henderson
On 10/12/18 10:30 AM, Bastian Koppelmann wrote: > +static bool trans_jal(DisasContext *ctx, arg_jal *a, uint32_t insn) > +{ > +CPURISCVState *env = current_cpu->env_ptr; > +gen_jal(env, ctx, a->rd, a->imm); I think you should go ahead and put env into ctx, which is probably where it

[Qemu-devel] [PATCH 02/28] target/riscv: Convert RVXI branch insns to decodetree

2018-10-12 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn32.decode | 19 + target/riscv/insn_trans/trans_rvi.inc.c | 52 + target/riscv/translate.c| 19 + 3 files changed, 72 insertions(+), 18