Re: [Qemu-devel] [PATCH 02/38] pci: split exit and finalize

2013-09-17 Thread Paolo Bonzini
Il 17/09/2013 11:56, Paolo Bonzini ha scritto: > Yes. do_pci_unregister_device marks the point where the guest will not > be able to submit new requests to the device, but there may be previous > requests pending. because you could have something like this: Michael pointed out offlist that the pr

Re: [Qemu-devel] [PATCH 02/38] pci: split exit and finalize

2013-09-17 Thread Michael S. Tsirkin
On Tue, Sep 03, 2013 at 02:32:53PM +0200, Paolo Bonzini wrote: > When converting devices to use out-of-BQL memory access, destruction > needs to be done in two phases. First, the device is unrealized; > at this point, pending memory accesses can still be completed, but > no new accesses will be st

Re: [Qemu-devel] [PATCH 02/38] pci: split exit and finalize

2013-09-17 Thread Paolo Bonzini
Il 17/09/2013 11:16, Michael S. Tsirkin ha scritto: > On Tue, Sep 03, 2013 at 02:32:53PM +0200, Paolo Bonzini wrote: >> When converting devices to use out-of-BQL memory access, destruction >> needs to be done in two phases. First, the device is unrealized; >> at this point, pending memory accesses

Re: [Qemu-devel] [PATCH 02/38] pci: split exit and finalize

2013-09-17 Thread Michael S. Tsirkin
On Tue, Sep 03, 2013 at 02:32:53PM +0200, Paolo Bonzini wrote: > When converting devices to use out-of-BQL memory access, destruction > needs to be done in two phases. First, the device is unrealized; > at this point, pending memory accesses can still be completed, but > no new accesses will be st

[Qemu-devel] [PATCH 02/38] pci: split exit and finalize

2013-09-03 Thread Paolo Bonzini
When converting devices to use out-of-BQL memory access, destruction needs to be done in two phases. First, the device is unrealized; at this point, pending memory accesses can still be completed, but no new accesses will be started. The second part is freeing the device, which happens only after