Re: [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling

2015-12-13 Thread David Gibson
On Fri, Dec 11, 2015 at 02:10:40PM +0530, Bharata B Rao wrote: > On Fri, Dec 11, 2015 at 5:41 AM, David Gibson > wrote: > > The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > > all errors with error_setg(_abort, ...). That's correct for > >

Re: [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling

2015-12-13 Thread David Gibson
On Fri, Dec 11, 2015 at 08:01:39AM -0700, Eric Blake wrote: > On 12/10/2015 05:11 PM, David Gibson wrote: > > The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > > all errors with error_setg(_abort, ...). That's correct for > > spapr_reset_htab() - if anything goes wrong

Re: [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling

2015-12-11 Thread Eric Blake
On 12/10/2015 05:11 PM, David Gibson wrote: > The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > all errors with error_setg(_abort, ...). That's correct for > spapr_reset_htab() - if anything goes wrong there, there's really nothing > we can do about it. For

Re: [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling

2015-12-11 Thread Bharata B Rao
On Fri, Dec 11, 2015 at 5:41 AM, David Gibson wrote: > The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > all errors with error_setg(_abort, ...). That's correct for > spapr_reset_htab() - if anything goes wrong there, there's really nothing >

[Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling

2015-12-10 Thread David Gibson
The spapr_alloc_htab() and spapr_reset_htab() functions currently handle all errors with error_setg(_abort, ...). That's correct for spapr_reset_htab() - if anything goes wrong there, there's really nothing we can do about it. For spapr_alloc_htab() _fatal would make more sense, since it occurs