Re: [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()

2017-03-03 Thread Kevin Wolf
Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben: > As a bdrv_create() method, sd_create() must set an error and return > negative errno on failure. It prints the error instead of setting it > when connect_to_sdog() fails. Fix that. > > While there, return the value of connect_to_sdog()

Re: [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()

2017-03-02 Thread Philippe Mathieu-Daudé
On 03/02/2017 06:43 PM, Markus Armbruster wrote: As a bdrv_create() method, sd_create() must set an error and return negative errno on failure. It prints the error instead of setting it when connect_to_sdog() fails. Fix that. While there, return the value of connect_to_sdog() like we do elsewh

Re: [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > As a bdrv_create() method, sd_create() must set an error and return > negative errno on failure. It prints the error instead of setting it > when connect_to_sdog() fails. Fix that. > > While there, return the value of connect_to_sdog() like we d

[Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()

2017-03-02 Thread Markus Armbruster
As a bdrv_create() method, sd_create() must set an error and return negative errno on failure. It prints the error instead of setting it when connect_to_sdog() fails. Fix that. While there, return the value of connect_to_sdog() like we do elsewhere, instead of -EIO. No functional change, as con