Re: [Qemu-devel] [PATCH 03/35] atapi: move GESN definitions to scsi-defs.h

2011-10-17 Thread Kevin Wolf
Am 13.10.2011 13:03, schrieb Paolo Bonzini: As a complement to the previous patch, move definitions for GET EVENT STATUS NOTIFICATION from the two functions to scsi-defs.h. The NCR_* constants are just bit values corresponding to the ENC_* values, with no offsets even, so keep just one copy.

Re: [Qemu-devel] [PATCH 03/35] atapi: move GESN definitions to scsi-defs.h

2011-10-17 Thread Paolo Bonzini
On 10/17/2011 03:41 PM, Kevin Wolf wrote: I'm not sure about the NCR_* constants. They happen to be shifted values, but the spec doesn't define them as such but has two separate tables for them. Yeah, on the other hand the spec has hints that they are really the same thing: 1) one is called

[Qemu-devel] [PATCH 03/35] atapi: move GESN definitions to scsi-defs.h

2011-10-13 Thread Paolo Bonzini
As a complement to the previous patch, move definitions for GET EVENT STATUS NOTIFICATION from the two functions to scsi-defs.h. The NCR_* constants are just bit values corresponding to the ENC_* values, with no offsets even, so keep just one copy. Signed-off-by: Paolo Bonzini