Re: [Qemu-devel] [PATCH 04/10] Translate offsets to destination address space

2015-05-19 Thread Michael R. Hines
On 04/20/2015 10:57 AM, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as being offsets within a particular RAMBlock, however they appear to actually be offsets within

Re: [Qemu-devel] [PATCH 04/10] Translate offsets to destination address space

2015-05-19 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 04/20/2015 10:57 AM, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as being offsets within a particular

Re: [Qemu-devel] [PATCH 04/10] Translate offsets to destination address space

2015-05-19 Thread Michael R. Hines
On 05/19/2015 01:44 PM, Dr. David Alan Gilbert wrote: * Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 04/20/2015 10:57 AM, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister

Re: [Qemu-devel] [PATCH 04/10] Translate offsets to destination address space

2015-05-19 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 05/19/2015 01:44 PM, Dr. David Alan Gilbert wrote: * Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 04/20/2015 10:57 AM, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The 'offset' field

[Qemu-devel] [PATCH 04/10] Translate offsets to destination address space

2015-04-20 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as being offsets within a particular RAMBlock, however they appear to actually be offsets within the ram_addr_t space. The code currently assumes that the