Re: [Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

2016-01-08 Thread Peter Crosthwaite
On Thu, Jan 7, 2016 at 10:09 AM, Peter Maydell wrote: > On 20 December 2015 at 20:51, Peter Crosthwaite > wrote: >> On Sun, Dec 20, 2015 at 9:10 AM, Peter Maydell >> wrote: >>> For user-level back compat I think we

Re: [Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

2015-12-20 Thread Peter Crosthwaite
On Sun, Dec 20, 2015 at 3:18 PM, Peter Maydell wrote: > On 20 December 2015 at 20:51, Peter Crosthwaite > wrote: >> On Sun, Dec 20, 2015 at 9:10 AM, Peter Maydell >> wrote: >>> On 19 December 2015 at 21:38, Peter

Re: [Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

2015-12-20 Thread Peter Maydell
On 20 December 2015 at 20:51, Peter Crosthwaite wrote: > On Sun, Dec 20, 2015 at 9:10 AM, Peter Maydell > wrote: >> On 19 December 2015 at 21:38, Peter Crosthwaite >> wrote: >>> On Fri, Dec 11, 2015 at 04:37:05PM

Re: [Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

2015-12-20 Thread Peter Maydell
On 19 December 2015 at 21:38, Peter Crosthwaite wrote: > On Fri, Dec 11, 2015 at 04:37:05PM +, Peter Maydell wrote: >> +bool sdbus_get_inserted(SDBus *sdbus) >> +{ >> +SDState *card = get_card(sdbus); >> + >> +if (card) { >> +SDClass *sc =

Re: [Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

2015-12-20 Thread Peter Crosthwaite
On Sun, Dec 20, 2015 at 9:10 AM, Peter Maydell wrote: > On 19 December 2015 at 21:38, Peter Crosthwaite > wrote: >> On Fri, Dec 11, 2015 at 04:37:05PM +, Peter Maydell wrote: >>> +bool sdbus_get_inserted(SDBus *sdbus) >>> +{ >>> +

Re: [Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

2015-12-19 Thread Peter Crosthwaite
On Fri, Dec 11, 2015 at 04:37:05PM +, Peter Maydell wrote: > Add a QOM bus for SD cards to plug in to. > > Note that since sd_enable() is used only by one board and there > only as part of a broken implementation, we do not provide it in > the SDBus API (but instead add a warning comment

[Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

2015-12-11 Thread Peter Maydell
Add a QOM bus for SD cards to plug in to. Note that since sd_enable() is used only by one board and there only as part of a broken implementation, we do not provide it in the SDBus API (but instead add a warning comment about the old function). Whoever converts OMAP and the nseries boards to QOM