Re: [Qemu-devel] [PATCH 04/14] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

2019-05-05 Thread Richard Henderson
On 5/5/19 2:52 AM, Mark Cave-Ayland wrote: > Right, it looks like VSX_CMP is the culprit here. Am I right in thinking that > it's > best to remove the opc parameter from GEN_VSX_HELPER_X3 above, and then have a > separate gen and helper function for just the VSX_CMP instructions? > Presumably

Re: [Qemu-devel] [PATCH 04/14] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

2019-05-05 Thread Mark Cave-Ayland
On 30/04/2019 17:36, Richard Henderson wrote: > On 4/28/19 7:38 AM, Mark Cave-Ayland wrote: >> +#define GEN_VSX_HELPER_X3(name, op1, op2, inval, type) >> \ >> +static void gen_##name(DisasContext *ctx) >> \ >> +{

Re: [Qemu-devel] [PATCH 04/14] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

2019-04-30 Thread Richard Henderson
On 4/28/19 7:38 AM, Mark Cave-Ayland wrote: > +#define GEN_VSX_HELPER_X3(name, op1, op2, inval, type) > \ > +static void gen_##name(DisasContext *ctx) > \ > +{ >

[Qemu-devel] [PATCH 04/14] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

2019-04-28 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X3 macro which performs the decode based upon xT, xA and xB at translation time. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 48 --- target/ppc/helper.h