Re: [Qemu-devel] [PATCH 04/16] acpi: Make acpi_setup() get PCMachineState as argument

2015-12-08 Thread Eduardo Habkost
On Mon, Dec 07, 2015 at 05:24:27PM +0200, Marcel Apfelbaum wrote: > On 12/02/2015 03:46 AM, Eduardo Habkost wrote: > >Lots of PcGuestInfo fields are duplicates of PCMachineClass or > >PCMachineState fields. Pass PCMachineState as argument to > >acpi_setup(), so we can simply let the ACPI code use t

Re: [Qemu-devel] [PATCH 04/16] acpi: Make acpi_setup() get PCMachineState as argument

2015-12-07 Thread Marcel Apfelbaum
On 12/02/2015 03:46 AM, Eduardo Habkost wrote: Lots of PcGuestInfo fields are duplicates of PCMachineClass or PCMachineState fields. Pass PCMachineState as argument to acpi_setup(), so we can simply let the ACPI code use those fields directly. I completely agree with removing duplicated fields

[Qemu-devel] [PATCH 04/16] acpi: Make acpi_setup() get PCMachineState as argument

2015-12-01 Thread Eduardo Habkost
Lots of PcGuestInfo fields are duplicates of PCMachineClass or PCMachineState fields. Pass PCMachineState as argument to acpi_setup(), so we can simply let the ACPI code use those fields directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 3 ++- hw/i386/acpi-build.h | 2 +- hw/i3