Re: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree

2018-10-19 Thread Palmer Dabbelt
On Fri, 19 Oct 2018 04:00:33 PDT (-0700), kbast...@mail.uni-paderborn.de wrote: Hi Richard, On 10/12/18 8:46 PM, Richard Henderson wrote: On 10/12/18 10:30 AM, Bastian Koppelmann wrote: +static bool trans_andi(DisasContext *ctx, arg_andi *a, uint32_t insn) +{ +gen_arith_imm(ctx,

Re: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree

2018-10-19 Thread Bastian Koppelmann
Hi Richard, On 10/12/18 8:46 PM, Richard Henderson wrote: On 10/12/18 10:30 AM, Bastian Koppelmann wrote: +static bool trans_andi(DisasContext *ctx, arg_andi *a, uint32_t insn) +{ +gen_arith_imm(ctx, OPC_RISC_ANDI, a->rd, a->rs1, a->imm); +return true; +} +static bool

Re: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree

2018-10-12 Thread Richard Henderson
On 10/12/18 10:30 AM, Bastian Koppelmann wrote: > +static bool trans_andi(DisasContext *ctx, arg_andi *a, uint32_t insn) > +{ > +gen_arith_imm(ctx, OPC_RISC_ANDI, a->rd, a->rs1, a->imm); > +return true; > +} > +static bool trans_slli(DisasContext *ctx, arg_slli *a, uint32_t insn) > +{ > +

[Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree

2018-10-12 Thread Bastian Koppelmann
we cannot remove the call to gen_arith() in decode_RV32_64G() since it is used to translate multiply instructions. Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn32.decode | 36 target/riscv/insn_trans/trans_rvi.inc.c | 221