Re: [Qemu-devel] [PATCH 04/67] target/arm: Remove offset argument to gen_exception_internal_insn

2019-08-06 Thread Peter Maydell
On Tue, 30 Jul 2019 at 03:11, Richard Henderson wrote: > > On 7/29/19 6:52 AM, Peter Maydell wrote: > > I'm not so convinced about this one -- gen_exception_insn() > > and gen_exception_internal_insn() shouldn't have the > > same pattern of function prototype but different semantics > > like this,

Re: [Qemu-devel] [PATCH 04/67] target/arm: Remove offset argument to gen_exception_internal_insn

2019-07-29 Thread Richard Henderson
On 7/29/19 6:52 AM, Peter Maydell wrote: > I'm not so convinced about this one -- gen_exception_insn() > and gen_exception_internal_insn() shouldn't have the > same pattern of function prototype but different semantics > like this, it's confusing. It happens that both the cases > of wanting to gene

Re: [Qemu-devel] [PATCH 04/67] target/arm: Remove offset argument to gen_exception_internal_insn

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > The actual argument is 0 for all callers. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/arm/translate.c b/target/arm/translate.

[Qemu-devel] [PATCH 04/67] target/arm: Remove offset argument to gen_exception_internal_insn

2019-07-26 Thread Richard Henderson
The actual argument is 0 for all callers. Signed-off-by: Richard Henderson --- target/arm/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 19b126d4f3..0848fb933a 100644 --- a/target/arm/translate.c +++ b