Re: [Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2015-12-20 Thread Peter Maydell
On 19 December 2015 at 21:39, Peter Crosthwaite wrote: > On Fri, Dec 11, 2015 at 04:37:06PM +, Peter Maydell wrote: >> +carddev = qdev_create(qdev_get_child_bus(dev, "sd-bus"), TYPE_SD); >> +qdev_prop_set_drive(carddev, "drive", blk, errp); >> +if

Re: [Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2015-12-19 Thread Peter Crosthwaite
On Fri, Dec 11, 2015 at 04:37:06PM +, Peter Maydell wrote: > Update the SDHCI code to use the new SDBus APIs. > > This commit introduces the new command line options required > to connect a disk to sdhci-pci: > > -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive > >

[Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2015-12-11 Thread Peter Maydell
Update the SDHCI code to use the new SDBus APIs. This commit introduces the new command line options required to connect a disk to sdhci-pci: -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive Signed-off-by: Peter Maydell --- hw/sd/sdhci.c |

Re: [Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 19:01, Kevin O'Connor wrote: > On Fri, Dec 11, 2015 at 04:37:06PM +, Peter Maydell wrote: >> Update the SDHCI code to use the new SDBus APIs. >> >> This commit introduces the new command line options required >> to connect a disk to sdhci-pci: >> >>

Re: [Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

2015-12-11 Thread Kevin O'Connor
On Fri, Dec 11, 2015 at 04:37:06PM +, Peter Maydell wrote: > Update the SDHCI code to use the new SDBus APIs. > > This commit introduces the new command line options required > to connect a disk to sdhci-pci: > > -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive I can't