Re: [Qemu-devel] [PATCH 05/11] pseries: Cleanup error handling in spapr_vga_init()

2015-12-13 Thread David Gibson
On Fri, Dec 11, 2015 at 10:35:58AM +0100, Thomas Huth wrote: > On 11/12/15 01:11, David Gibson wrote: > > Use error_setg() to return an error rather than an explicit exit(). > > Previously it was an exit(0) instead of a non-zero exit code, which was > > simply a bug. > > > > Also improve the

Re: [Qemu-devel] [PATCH 05/11] pseries: Cleanup error handling in spapr_vga_init()

2015-12-11 Thread Thomas Huth
On 11/12/15 01:11, David Gibson wrote: > Use error_setg() to return an error rather than an explicit exit(). > Previously it was an exit(0) instead of a non-zero exit code, which was > simply a bug. > > Also improve the error message. > > Signed-off-by: David Gibson

[Qemu-devel] [PATCH 05/11] pseries: Cleanup error handling in spapr_vga_init()

2015-12-10 Thread David Gibson
Use error_setg() to return an error rather than an explicit exit(). Previously it was an exit(0) instead of a non-zero exit code, which was simply a bug. Also improve the error message. Signed-off-by: David Gibson --- hw/ppc/spapr.c | 10 +- 1 file changed,