Re: [Qemu-devel] [PATCH 05/11] target-i386: cpu: replace custom apic-id setter/getter with static property

2016-06-28 Thread Eduardo Habkost
On Tue, Jun 28, 2016 at 08:43:59AM +0200, Igor Mammedov wrote: > On Mon, 27 Jun 2016 14:55:24 -0300 > Eduardo Habkost wrote: > > > On Thu, Jun 23, 2016 at 04:54:23PM +0200, Igor Mammedov wrote: > > > custom apic-id setter/getter doesn't do any property specific > > > checks anymorer, so clean it

Re: [Qemu-devel] [PATCH 05/11] target-i386: cpu: replace custom apic-id setter/getter with static property

2016-06-27 Thread Igor Mammedov
On Mon, 27 Jun 2016 14:55:24 -0300 Eduardo Habkost wrote: > On Thu, Jun 23, 2016 at 04:54:23PM +0200, Igor Mammedov wrote: > > custom apic-id setter/getter doesn't do any property specific > > checks anymorer, so clean it up and use more compact static > > property DEFINE_PROP_UINT32 instead. > >

Re: [Qemu-devel] [PATCH 05/11] target-i386: cpu: replace custom apic-id setter/getter with static property

2016-06-27 Thread Eduardo Habkost
On Thu, Jun 23, 2016 at 04:54:23PM +0200, Igor Mammedov wrote: > custom apic-id setter/getter doesn't do any property specific > checks anymorer, so clean it up and use more compact static > property DEFINE_PROP_UINT32 instead. > > Signed-off-by: Igor Mammedov > --- > target-i386/cpu.c | 45

[Qemu-devel] [PATCH 05/11] target-i386: cpu: replace custom apic-id setter/getter with static property

2016-06-23 Thread Igor Mammedov
custom apic-id setter/getter doesn't do any property specific checks anymorer, so clean it up and use more compact static property DEFINE_PROP_UINT32 instead. Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 45 ++--- 1 file changed, 6 insertions(+), 3