Re: [Qemu-devel] [PATCH 05/11] wm8750: QOM'ify

2014-02-09 Thread Andreas Färber
Am 31.01.2014 15:34, schrieb Andreas Färber: > Replace usages of FROM_I2C_SLAVE() with QOM cast macro. > Rename parent field. > > Signed-off-by: Andreas Färber > --- > hw/audio/wm8750.c | 33 - > 1 file changed, 20 insertions(+), 13 deletions(-) Follow-up TODO: M

Re: [Qemu-devel] [PATCH 05/11] wm8750: QOM'ify

2014-02-08 Thread Peter Crosthwaite
On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote: > Replace usages of FROM_I2C_SLAVE() with QOM cast macro. > Rename parent field. A nit, but you are also "removing direct pointer derefence casts" [1] ... > > Signed-off-by: Andreas Färber > --- > hw/audio/wm8750.c | 33 +++

[Qemu-devel] [PATCH 05/11] wm8750: QOM'ify

2014-01-31 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Signed-off-by: Andreas Färber --- hw/audio/wm8750.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c index 6b5a349..c18f245 10