[Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

2018-10-01 Thread Philippe Mathieu-Daudé
Move from the legacy SysBusDevice::init method to using DeviceState::realize. Signed-off-by: Philippe Mathieu-Daudé --- hw/sh4/sh_pci.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c index 4ec2e35500..84c52df067 100644

Re: [Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

2018-10-02 Thread Peter Maydell
On 1 October 2018 at 23:09, Philippe Mathieu-Daudé wrote: > Move from the legacy SysBusDevice::init method to using DeviceState::realize. Comment says DeviceState::realize but the code is using PCIDevice::realize ? I didn't realize pci devices had their own realize method: what's the difference

Re: [Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

2018-10-02 Thread Cédric Le Goater
On 10/2/18 12:09 AM, Philippe Mathieu-Daudé wrote: > Move from the legacy SysBusDevice::init method to using DeviceState::realize. > > Signed-off-by: Philippe Mathieu-Daudé one question below, Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/sh4/sh_pci.c | 20 +--- > 1 f

Re: [Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

2018-10-02 Thread Philippe Mathieu-Daudé
On 10/2/18 3:13 PM, Peter Maydell wrote: > On 1 October 2018 at 23:09, Philippe Mathieu-Daudé wrote: >> Move from the legacy SysBusDevice::init method to using DeviceState::realize. > > Comment says DeviceState::realize but the code is using > PCIDevice::realize ? > > I didn't realize pci device

Re: [Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

2018-10-02 Thread Marcel Apfelbaum
Hi Philippe, Peter On 10/2/18 10:59 PM, Philippe Mathieu-Daudé wrote: On 10/2/18 3:13 PM, Peter Maydell wrote: On 1 October 2018 at 23:09, Philippe Mathieu-Daudé wrote: Move from the legacy SysBusDevice::init method to using DeviceState::realize. Comment says DeviceState::realize but the cod

Re: [Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

2018-10-02 Thread Philippe Mathieu-Daudé
On 10/2/18 10:37 PM, Marcel Apfelbaum wrote: > Hi Philippe, Peter > > On 10/2/18 10:59 PM, Philippe Mathieu-Daudé wrote: >> On 10/2/18 3:13 PM, Peter Maydell wrote: >>> On 1 October 2018 at 23:09, Philippe Mathieu-Daudé >>> wrote: Move from the legacy SysBusDevice::init method to using