Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:26, Jan Kiszka wrote: > Also note that the HPET is not a part of the PIIX, so composition is > wrong here. The RTC is again. Err, forgot my nonsense. The HPET is part of the PIIX. Dunno, I was somehow thinking of the IOAPIC while reading "HPET". Too few sleep, I guess... Jan --

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:56 AM, Jan Kiszka wrote: On 2012-01-31 15:54, Anthony Liguori wrote: On 01/31/2012 08:49 AM, Jan Kiszka wrote: On 2012-01-31 15:43, Anthony Liguori wrote: On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguori ---

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:54, Anthony Liguori wrote: > On 01/31/2012 08:49 AM, Jan Kiszka wrote: >> On 2012-01-31 15:43, Anthony Liguori wrote: >>> On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- >hw/hpet.c

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:49 AM, Jan Kiszka wrote: On 2012-01-31 15:43, Anthony Liguori wrote: On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguori --- hw/hpet.c| 38 +- hw/hpet_emul.h | 40 ++

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:43, Anthony Liguori wrote: > On 01/31/2012 08:26 AM, Jan Kiszka wrote: >> On 2012-01-26 20:00, Anthony Liguori wrote: >>> Signed-off-by: Anthony Liguori >>> --- >>> hw/hpet.c| 38 +- >>> hw/hpet_emul.h | 40 >>>

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguori --- hw/hpet.c| 38 +- hw/hpet_emul.h | 40 hw/mc146818rtc.c | 30 ++--- hw/mc146818rtc.h

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-26 20:00, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > hw/hpet.c| 38 +- > hw/hpet_emul.h | 40 > hw/mc146818rtc.c | 30 ++--- > hw/mc146818rtc.h | 27 +++ > hw/pc.

[Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-26 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/hpet.c| 38 +- hw/hpet_emul.h | 40 hw/mc146818rtc.c | 30 ++--- hw/mc146818rtc.h | 27 +++ hw/pc.c | 38 +-- hw/piix_pci