Re: [Qemu-devel] [PATCH 05/17] qapi: Avoid use of 'data' member of qapi unions

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:35PM -0700, Eric Blake wrote: > qapi code generators currently create a 'void *data' member as > part of the anonymous union embedded in the C struct corresponding > to a qapi union. However, directly assigning to this member of > the union feels a bit fishy, when we

[Qemu-devel] [PATCH 05/17] qapi: Avoid use of 'data' member of qapi unions

2016-02-19 Thread Eric Blake
qapi code generators currently create a 'void *data' member as part of the anonymous union embedded in the C struct corresponding to a qapi union. However, directly assigning to this member of the union feels a bit fishy, when we can directly use the rest of the struct instead. Signed-off-by: