Re: [Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creation

2011-10-04 Thread Anthony Liguori
On 10/04/2011 09:44 AM, Juan Quintela wrote: Anthony Liguori wrote: On 09/23/2011 07:56 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela I think this would fit better if it were migrate_new() or migrate_open(). It definitely should be in the form noun_verb and not noun_verb_noun(). R

Re: [Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creation

2011-10-04 Thread Juan Quintela
Anthony Liguori wrote: > On 09/23/2011 07:56 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > > I think this would fit better if it were migrate_new() or migrate_open(). > > It definitely should be in the form noun_verb and not noun_verb_noun(). > > Regards, You are the native speaker

Re: [Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creation

2011-10-04 Thread Anthony Liguori
On 09/23/2011 07:56 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela --- migration-exec.c | 16 +--- migration-fd.c | 16 +--- migration-tcp.c | 15 +-- migration-unix.c | 15 +-- migration.c | 29 +++

[Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creation

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 16 +--- migration-fd.c | 16 +--- migration-tcp.c | 15 +-- migration-unix.c | 15 +-- migration.c | 29 + migration.h | 11 +++ 6 file

[Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creation

2011-09-20 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 16 +--- migration-fd.c | 16 +--- migration-tcp.c | 15 +-- migration-unix.c | 15 +-- migration.c | 29 + migration.h | 11 +++ 6 file