Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/19/2017 07:28 PM, Dr. David Alan Gilbert wrote: > >> To sum it up although I'm currently leaning towards abandoning my idea > >> of two sections for two devices, I'm not comfortable with making the > >> call myself. I'm hoping for some

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

On 05/19/2017 07:28 PM, Dr. David Alan Gilbert wrote: >> To sum it up although I'm currently leaning towards abandoning my idea >> of two sections for two devices, I'm not comfortable with making the >> call myself. I'm hoping for some maintainer guidance (s390x, virtio >> and migration). >

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/15/2017 09:07 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 05/08/2017 08:42 PM, Dr. David Alan Gilbert wrote: > >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

On 05/15/2017 09:07 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/08/2017 08:42 PM, Dr. David Alan Gilbert wrote: >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: On 05/08/2017 07:59 PM, Dr. David Alan Gilbert wrote: [..]

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/08/2017 08:42 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 05/08/2017 07:59 PM, Dr. David Alan Gilbert wrote: > >> const VMStateDescription vmstate_virtio_ccw_dev = { >

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

On 05/08/2017 08:42 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/08/2017 07:59 PM, Dr. David Alan Gilbert wrote: >> const VMStateDescription vmstate_virtio_ccw_dev = { >> .name = "s390_virtio_ccw_dev", >> .version_id =

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

On Tue, 9 May 2017 19:05:28 +0200 Halil Pasic wrote: > From e92135590ab95cc565b37913de77a9ed17012933 Mon Sep 17 00:00:00 2001 > From: Halil Pasic > Date: Tue, 9 May 2017 16:01:50 +0200 > Subject: [PATCH 1/2] virtio-ccw: replace info with

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/08/2017 06:55 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> Let us use the freshly introduced vmstate migration helpers instead of > >> saving/loading the config manually. > >> > >> To

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

On 05/08/2017 06:55 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> Let us use the freshly introduced vmstate migration helpers instead of >> saving/loading the config manually. >> >> To achieve this we need to hack the config_vector which is a common >>

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/08/2017 07:59 PM, Dr. David Alan Gilbert wrote: > const VMStateDescription vmstate_virtio_ccw_dev = { > .name = "s390_virtio_ccw_dev", > .version_id = 1, > @@ -67,6 +93,14 @@ const VMStateDescription

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

On 05/08/2017 07:59 PM, Dr. David Alan Gilbert wrote: const VMStateDescription vmstate_virtio_ccw_dev = { .name = "s390_virtio_ccw_dev", .version_id = 1, @@ -67,6 +93,14 @@ const VMStateDescription vmstate_virtio_ccw_dev = {

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/08/2017 07:36 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> Let us use the freshly introduced vmstate migration helpers instead of > >> saving/loading the config manually. > >> > >> To

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

On 05/08/2017 07:36 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> Let us use the freshly introduced vmstate migration helpers instead of >> saving/loading the config manually. >> >> To achieve this we need to hack the config_vector which is a common >>

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Let us use the freshly introduced vmstate migration helpers instead of > saving/loading the config manually. > > To achieve this we need to hack the config_vector which is a common > VirtIO state in the middle of the VirtioCcwDevice state

Re: [Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Let us use the freshly introduced vmstate migration helpers instead of > saving/loading the config manually. > > To achieve this we need to hack the config_vector which is a common > VirtIO state in the middle of the VirtioCcwDevice state

[Qemu-devel] [PATCH 06/10] virtio-ccw: use vmstate way for config migration

Let us use the freshly introduced vmstate migration helpers instead of saving/loading the config manually. To achieve this we need to hack the config_vector which is a common VirtIO state in the middle of the VirtioCcwDevice state representation. This somewhat ugly but we have no choice because