Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 12:30, Pavel Dovgaluk ha scritto: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Il 27/08/2014 15:03, Pavel Dovgaluk ha scritto: > Hmm, probably not. The bug would not be other timers accessing the > APIC, because that would also call apic_sync_vapic and the only effe

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-09-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 15:03, Pavel Dovgaluk ha scritto: > >> > Hmm, probably not. The bug would not be other timers accessing the > >> > APIC, because that would also call apic_sync_vapic and the only effect > >> > would be an extra useless synchronizat

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 15:03, Pavel Dovgaluk ha scritto: >> > Hmm, probably not. The bug would not be other timers accessing the >> > APIC, because that would also call apic_sync_vapic and the only effect >> > would be an extra useless synchronization. The bug would happen if the >> > APIC is accessed by

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 14:16, Pavel Dovgaluk ha scritto: > >> > Can you use a vm_change_state_handler, or a QEMU_CLOCK_VIRTUAL timer > >> > with expiration time in the past (e.g. at time zero) to run the sync > >> > code as soon as possible? Then you can

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 14:16, Pavel Dovgaluk ha scritto: >> > Can you use a vm_change_state_handler, or a QEMU_CLOCK_VIRTUAL timer >> > with expiration time in the past (e.g. at time zero) to run the sync >> > code as soon as possible? Then you can preserve the current migration >> > format and avoid using

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > > vapic state should not be synchronized with APIC while loading, > > because APIC state could be not loaded yet at that moment. > > We just save vapic_paddr in

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > vapic state should not be synchronized with APIC while loading, > because APIC state could be not loaded yet at that moment. > We just save vapic_paddr in APIC VMState instead of synchronization. Can you use a vm_change_state_handler, or a QEMU_CL

[Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-26 Thread Pavel Dovgalyuk
vapic state should not be synchronized with APIC while loading, because APIC state could be not loaded yet at that moment. We just save vapic_paddr in APIC VMState instead of synchronization. Signed-off-by: Pavel Dovgalyuk --- hw/i386/kvmvapic.c | 22 +++- hw/intc/