On 09/14/2011 05:44 PM, Christoph Hellwig wrote:
Map it to bdrv_discard. The server can now expose NBD_FLAG_SEND_TRIM.
Note that discard support without a way to communicate the alignment/size
requirements,
Yep, especially because alignment can be as small as 512 for sparse raw,
and as high
On Thu, Sep 08, 2011 at 05:24:59PM +0200, Paolo Bonzini wrote:
> Map it to bdrv_discard. The server can now expose NBD_FLAG_SEND_TRIM.
Note that discard support without a way to communicate the alignment/size
requirements, and without the discard_zeroes_data flag is pretty much
useless. Can you
On 09/13/2011 03:58 PM, Kevin Wolf wrote:
> +case NBD_CMD_TRIM:
> +TRACE("Request type is TRIM");
> +bdrv_discard(bs, (request.from + dev_offset) / 512,
> + request.len / 512);
Errors are completely ignored? Does the NBD protocol not allow to return
a
Am 08.09.2011 17:24, schrieb Paolo Bonzini:
> Map it to bdrv_discard. The server can now expose NBD_FLAG_SEND_TRIM.
>
> Signed-off-by: Paolo Bonzini
> ---
> block/nbd.c | 31 +++
> nbd.c |9 -
> 2 files changed, 39 insertions(+), 1 deletions(-)
>
Map it to bdrv_discard. The server can now expose NBD_FLAG_SEND_TRIM.
Signed-off-by: Paolo Bonzini
---
block/nbd.c | 31 +++
nbd.c |9 -
2 files changed, 39 insertions(+), 1 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 5a7812c..964ca
