Re: [Qemu-devel] [PATCH 06/13] Add support for S390x system emulation

2009-11-25 Thread Alexander Graf
On 25.11.2009, at 12:46, Paul Brook wrote: >> --- a/target-s390x/cpu.h >> +++ b/target-s390x/cpu.h >> @@ -30,8 +30,7 @@ >> >> #include "softfloat.h" >> >> -#define NB_MMU_MODES 2 // guess >> -#define MMU_USER_IDX 0 // guess >> +#define NB_MMU_MODES 2 > > The fact that you're modifying a file y

Re: [Qemu-devel] [PATCH 06/13] Add support for S390x system emulation

2009-11-25 Thread Paul Brook
> --- a/target-s390x/cpu.h > +++ b/target-s390x/cpu.h > @@ -30,8 +30,7 @@ > > #include "softfloat.h" > > -#define NB_MMU_MODES 2 // guess > -#define MMU_USER_IDX 0 // guess > +#define NB_MMU_MODES 2 The fact that you're modifying a file you added earlier in the same patch series gives me very

[Qemu-devel] [PATCH 06/13] Add support for S390x system emulation

2009-11-24 Thread Alexander Graf
Let's enable the basics for system emulation so we can run virtual machines with KVM! Signed-off-by: Alexander Graf --- target-s390x/cpu.h| 153 - target-s390x/exec.h |5 + target-s390x/helper.c | 22 + targ