Re: [Qemu-devel] [PATCH 06/13] error: remove error_printf_unless_qmp()

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: monitor_vprintf() is called in the code path, and it will not print when monitor is in qmp mode, so checking monitor mode in error_printf_unless_qmp() is useless, remove it to simplify the code. Signed-off-by: Wenchao Xia

[Qemu-devel] [PATCH 06/13] error: remove error_printf_unless_qmp()

2013-10-18 Thread Wenchao Xia
monitor_vprintf() is called in the code path, and it will not print when monitor is in qmp mode, so checking monitor mode in error_printf_unless_qmp() is useless, remove it to simplify the code. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- hw/usb/bus.c|2 +-

Re: [Qemu-devel] [PATCH 06/13] error: remove error_printf_unless_qmp()

2013-10-18 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: monitor_vprintf() is called in the code path, and it will not print when monitor is in qmp mode, so checking monitor mode in error_printf_unless_qmp() is useless, remove it to simplify the code. Suggest to reword: error_printf_unless_qmp() is no