Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions

2017-04-24 Thread Daniel P. Berrange
On Mon, Apr 24, 2017 at 11:24:31AM +0200, Markus Armbruster wrote: > Fam Zheng writes: > > > On Mon, 04/24 09:28, Daniel P. Berrange wrote: > >> On Fri, Apr 21, 2017 at 08:27:02PM +0800, Fam Zheng wrote: > >> > Move opaque to 2nd instead of the 2nd to last, so that compilers

Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions

2017-04-24 Thread Markus Armbruster
Fam Zheng writes: > On Mon, 04/24 09:28, Daniel P. Berrange wrote: >> On Fri, Apr 21, 2017 at 08:27:02PM +0800, Fam Zheng wrote: >> > Move opaque to 2nd instead of the 2nd to last, so that compilers help >> > check with the convertion. >> >> Moving 'opaque' like this should not

Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions

2017-04-24 Thread Fam Zheng
On Mon, 04/24 09:28, Daniel P. Berrange wrote: > On Fri, Apr 21, 2017 at 08:27:02PM +0800, Fam Zheng wrote: > > Move opaque to 2nd instead of the 2nd to last, so that compilers help > > check with the convertion. > > Moving 'opaque' like this should not be done. > > If you want the compiler to

Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions

2017-04-24 Thread Daniel P. Berrange
On Fri, Apr 21, 2017 at 08:27:02PM +0800, Fam Zheng wrote: > Move opaque to 2nd instead of the 2nd to last, so that compilers help > check with the convertion. Moving 'opaque' like this should not be done. If you want the compiler to check the fixes, it should be done in just two stages. First

Re: [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions

2017-04-21 Thread Eric Blake
On 04/21/2017 07:27 AM, Fam Zheng wrote: > Move opaque to 2nd instead of the 2nd to last, so that compilers help > check with the convertion. s/convertion/conversion/ > > Signed-off-by: Fam Zheng > --- > block/crypto.c| 12 ++-- > crypto/block-luks.c

[Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions

2017-04-21 Thread Fam Zheng
Move opaque to 2nd instead of the 2nd to last, so that compilers help check with the convertion. Signed-off-by: Fam Zheng --- block/crypto.c| 12 ++-- crypto/block-luks.c | 21 + include/crypto/block.h| 12 ++--