Re: [Qemu-devel] [PATCH 06/14] trace: Trace entry point of balloon request handler

2010-08-23 Thread Anthony Liguori
On 08/23/2010 05:10 AM, Stefan Hajnoczi wrote: On Sun, Aug 22, 2010 at 04:41:44PM -0500, Anthony Liguori wrote: ram_addr_t is not necessarily an unsigned long. It's actually a uint64_t. Integer promotion should handle this in most cases but having the definition in two different places wo

Re: [Qemu-devel] [PATCH 06/14] trace: Trace entry point of balloon request handler

2010-08-23 Thread Stefan Hajnoczi
On Sun, Aug 22, 2010 at 04:41:44PM -0500, Anthony Liguori wrote: > ram_addr_t is not necessarily an unsigned long. It's actually a > uint64_t. Integer promotion should handle this in most cases but > having the definition in two different places worries me a bit. I thought it is unsigned long:

Re: [Qemu-devel] [PATCH 06/14] trace: Trace entry point of balloon request handler

2010-08-22 Thread Anthony Liguori
On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote: From: Prerna Saxena Signed-off-by: Prerna Saxena Signed-off-by: Stefan Hajnoczi --- balloon.c|2 ++ trace-events |4 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/balloon.c b/balloon.c index 8e0b7f1..0021fef 100

[Qemu-devel] [PATCH 06/14] trace: Trace entry point of balloon request handler

2010-08-12 Thread Stefan Hajnoczi
From: Prerna Saxena Signed-off-by: Prerna Saxena Signed-off-by: Stefan Hajnoczi --- balloon.c|2 ++ trace-events |4 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/balloon.c b/balloon.c index 8e0b7f1..0021fef 100644 --- a/balloon.c +++ b/balloon.c @@ -29,6 +29,