Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Thomas Huth
On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch makes solookup() compatible with varying address families. Also, > this function was only compatible with TCP. Having the socket list in > argument, it is now compatible with UDP too. Finally,

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:29:44 +0100, wrote: > Thomas Huth, on Fri 11 Dec 2015 16:06:22 +0100, wrote: > > On 11/12/15 01:15, Samuel Thibault wrote: > > > From: Guillaume Subiron > > > > > > This patch makes solookup() compatible with varying address families.

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:38:19 +0100, wrote: > I'll however have a look at introducing the optimizations etc. first, so > that both making solookup use sockaddr and introducing sockaddr_equal > looks natural. Yes, it seems to be working very nicely. Samuel

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:51:02 +0100, wrote: > Samuel Thibault, on Fri 11 Dec 2015 20:38:19 +0100, wrote: > > I'll however have a look at introducing the optimizations etc. first, so > > that both making solookup use sockaddr and introducing sockaddr_equal > > looks natural. > >

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 16:06:22 +0100, wrote: > On 11/12/15 01:15, Samuel Thibault wrote: > > From: Guillaume Subiron > > > > This patch makes solookup() compatible with varying address families. Also, > > this function was only compatible with TCP. Having the

[Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-10 Thread Samuel Thibault
From: Guillaume Subiron This patch makes solookup() compatible with varying address families. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the

[Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-07-28 Thread Samuel Thibault
This patch makes solookup() compatible with varying address families. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned

[Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2014-03-30 Thread Samuel Thibault
This patch makes solookup() compatible with varying address families. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned