Re: [Qemu-devel] [PATCH 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-09 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > Before: > $ ./qemu-io-old > qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo > Failed to parse URL : foo > qemu-io-old: can't open device (null): Could not open 'foo': Invalid > argument > > After: > $ ./qemu-io > qemu

[Qemu-devel] [PATCH 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-09 Thread Paolo Bonzini
Before: $ ./qemu-io-old qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo Failed to parse URL : foo qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument After: $ ./qemu-io qemu-io> open -r -o file.driver=iscsi,file.filename=foo qemu-i