On 20.01.2016 06:53, Alexey Kardashevskiy wrote:
> On 01/20/2016 03:53 PM, Eric Blake wrote:
>> On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote:
>>
You could drop the redundant () while touching this, as in:
>>>
>>>
>>> Seriously? Why? I personally find it really annoying (but I stay silent
Alexey Kardashevskiy writes:
> On 01/20/2016 06:18 PM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote:
>>>
> You could drop the redundant () while touching this, as in:
Seriously? Why? I personally find it really annoyi
On 01/20/2016 06:18 PM, Markus Armbruster wrote:
Eric Blake writes:
On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote:
You could drop the redundant () while touching this, as in:
Seriously? Why? I personally find it really annoying (but I stay silent)
when people omit braces in cases lik
Eric Blake writes:
> On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote:
>
>>> You could drop the redundant () while touching this, as in:
>>
>>
>> Seriously? Why? I personally find it really annoying (but I stay silent)
>> when people omit braces in cases like this.
>>
>>
>>> assert(token >=
On 01/20/2016 03:53 PM, Eric Blake wrote:
On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote:
You could drop the redundant () while touching this, as in:
Seriously? Why? I personally find it really annoying (but I stay silent)
when people omit braces in cases like this.
assert(token >= RT
On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote:
>> You could drop the redundant () while touching this, as in:
>
>
> Seriously? Why? I personally find it really annoying (but I stay silent)
> when people omit braces in cases like this.
>
>
>> assert(token >= RTAS_TOKEN_BASE && token < RTAS
On 01/20/2016 09:58 AM, Eric Blake wrote:
On 01/15/2016 05:00 AM, David Gibson wrote:
The errors detected in this function necessarily indicate bugs in the rest
of the qemu code, rather than an external or configuration problem.
So, a simple assert() is more appropriate than any more complex er
On 01/15/2016 05:00 AM, David Gibson wrote:
> The errors detected in this function necessarily indicate bugs in the rest
> of the qemu code, rather than an external or configuration problem.
>
> So, a simple assert() is more appropriate than any more complex error
> reporting.
>
> Signed-off-by:
The errors detected in this function necessarily indicate bugs in the rest
of the qemu code, rather than an external or configuration problem.
So, a simple assert() is more appropriate than any more complex error
reporting.
Signed-off-by: David Gibson
---
hw/ppc/spapr_rtas.c | 12 +++-
