Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-21 Thread John Snow
On 6/21/19 5:48 PM, Max Reitz wrote: > On 21.06.19 22:58, John Snow wrote: >> >> >> On 6/21/19 9:44 AM, Vladimir Sementsov-Ogievskiy wrote: > > [...] > > Just chiming in on this: > >>> "So on cancel and abort you synchronize bitmap too?" >> >> I will concede that this means that if you ask fo

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-21 Thread Max Reitz
On 21.06.19 22:58, John Snow wrote: > > > On 6/21/19 9:44 AM, Vladimir Sementsov-Ogievskiy wrote: [...] Just chiming in on this: >> "So on cancel and abort you synchronize bitmap too?" > > I will concede that this means that if you ask for a bitmap backup with > the 'always' policy and, for w

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-21 Thread John Snow
On 6/21/19 9:44 AM, Vladimir Sementsov-Ogievskiy wrote: > 21.06.2019 16:08, Vladimir Sementsov-Ogievskiy wrote: >> 21.06.2019 15:59, Vladimir Sementsov-Ogievskiy wrote: >>> 21.06.2019 15:57, Vladimir Sementsov-Ogievskiy wrote: ^ Home Run! I'm going to reply to all four of these mails at once b

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
21.06.2019 16:08, Vladimir Sementsov-Ogievskiy wrote: > 21.06.2019 15:59, Vladimir Sementsov-Ogievskiy wrote: >> 21.06.2019 15:57, Vladimir Sementsov-Ogievskiy wrote: >>> 20.06.2019 4:03, John Snow wrote: This adds an "always" policy for bitmap synchronization. Regardless of if the job su

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
21.06.2019 15:59, Vladimir Sementsov-Ogievskiy wrote: > 21.06.2019 15:57, Vladimir Sementsov-Ogievskiy wrote: >> 20.06.2019 4:03, John Snow wrote: >>> This adds an "always" policy for bitmap synchronization. Regardless of if >>> the job succeeds or fails, the bitmap is *always* synchronized. This m

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
21.06.2019 15:57, Vladimir Sementsov-Ogievskiy wrote: > 20.06.2019 4:03, John Snow wrote: >> This adds an "always" policy for bitmap synchronization. Regardless of if >> the job succeeds or fails, the bitmap is *always* synchronized. This means >> that for backups that fail part-way through, the bi

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
20.06.2019 4:03, John Snow wrote: > This adds an "always" policy for bitmap synchronization. Regardless of if > the job succeeds or fails, the bitmap is *always* synchronized. This means > that for backups that fail part-way through, the bitmap retains a record of > which sectors need to be copied

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-20 Thread Max Reitz
On 20.06.19 20:44, John Snow wrote: > > > On 6/20/19 1:00 PM, Max Reitz wrote: >> On 20.06.19 03:03, John Snow wrote: >>> This adds an "always" policy for bitmap synchronization. Regardless of if >>> the job succeeds or fails, the bitmap is *always* synchronized. This means >>> that for backups t

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-20 Thread John Snow
On 6/20/19 1:00 PM, Max Reitz wrote: > On 20.06.19 03:03, John Snow wrote: >> This adds an "always" policy for bitmap synchronization. Regardless of if >> the job succeeds or fails, the bitmap is *always* synchronized. This means >> that for backups that fail part-way through, the bitmap retains

Re: [Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-20 Thread Max Reitz
On 20.06.19 03:03, John Snow wrote: > This adds an "always" policy for bitmap synchronization. Regardless of if > the job succeeds or fails, the bitmap is *always* synchronized. This means > that for backups that fail part-way through, the bitmap retains a record of > which sectors need to be copie

[Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-19 Thread John Snow
This adds an "always" policy for bitmap synchronization. Regardless of if the job succeeds or fails, the bitmap is *always* synchronized. This means that for backups that fail part-way through, the bitmap retains a record of which sectors need to be copied out to accomplish a new backup using the o