Re: [Qemu-devel] [PATCH 07/12] json-parser: always set an error if return NULL

2018-07-20 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jul 17, 2018 at 9:06 AM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Let's make json_parser_parse_err() suck less, and simplify caller >>> error handling. >> >> Missing: >> >>* monitor.c handle_qmp_command(): drop workaround >>

Re: [Qemu-devel] [PATCH 07/12] json-parser: always set an error if return NULL

2018-07-19 Thread Marc-André Lureau
Hi On Tue, Jul 17, 2018 at 9:06 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Let's make json_parser_parse_err() suck less, and simplify caller >> error handling. > > Missing: > >* monitor.c handle_qmp_command(): drop workaround > >> * qga/main.c process_event() doesn't

Re: [Qemu-devel] [PATCH 07/12] json-parser: always set an error if return NULL

2018-07-17 Thread Markus Armbruster
Marc-André Lureau writes: > Let's make json_parser_parse_err() suck less, and simplify caller > error handling. Missing: * monitor.c handle_qmp_command(): drop workaround > * qga/main.c process_event() doesn't need further changes after >previous cleanup. "Doesn't need further

[Qemu-devel] [PATCH 07/12] json-parser: always set an error if return NULL

2018-07-06 Thread Marc-André Lureau
Let's make json_parser_parse_err() suck less, and simplify caller error handling. * qga/main.c process_event() doesn't need further changes after previous cleanup. * qobject/json-parser.c json_parser_parse() Ignores the error. * qobject/qjson.c qobject_from_jsonv() via parse_json() -