Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 20:33:32 +0100 Paolo Bonzini wrote: > On 14/11/2016 19:49, Alex Williamson wrote: > > On Mon, 14 Nov 2016 19:10:54 +0100 > > Paolo Bonzini wrote: > > > >> On 14/11/2016 18:09, Alex Williamson wrote: > >>> Hmm, fixed yet not

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 19:49, Alex Williamson wrote: > On Mon, 14 Nov 2016 19:10:54 +0100 > Paolo Bonzini wrote: > >> On 14/11/2016 18:09, Alex Williamson wrote: >>> Hmm, fixed yet not fixed. I get a nice shutdown and it even eliminates >>> a cpu spike shown in virt-manager at the

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 19:10:54 +0100 Paolo Bonzini wrote: > On 14/11/2016 18:09, Alex Williamson wrote: > > Hmm, fixed yet not fixed. I get a nice shutdown and it even eliminates > > a cpu spike shown in virt-manager at the end of shutdown that was > > typical previously, but

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 18:09, Alex Williamson wrote: > Hmm, fixed yet not fixed. I get a nice shutdown and it even eliminates > a cpu spike shown in virt-manager at the end of shutdown that was > typical previously, but then I noticed dmesg showing me segfaults, so I > hooked up gdb and: Well, that I

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 14:41:42 +0100 Paolo Bonzini wrote: > On 11/11/2016 22:03, Alex Williamson wrote: > > On Fri, 11 Nov 2016 21:24:33 +0100 > > Paolo Bonzini wrote: > >> If you can post a backtrace of all threads at the time of the hang, from > >>

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Paolo Bonzini
On 11/11/2016 22:03, Alex Williamson wrote: > On Fri, 11 Nov 2016 21:24:33 +0100 > Paolo Bonzini wrote: >> If you can post a backtrace of all threads at the time of the hang, from >> origin/master (so without vhost, and not at ad07cd6) that could help. > > Yes, it occurs

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-11 Thread Alex Williamson
On Fri, 11 Nov 2016 21:24:33 +0100 Paolo Bonzini wrote: > On 11/11/2016 05:09, Alex Williamson wrote: > > On Fri, 21 Oct 2016 22:48:10 +0200 > > Paolo Bonzini wrote: > > > >> Override start_ioeventfd and stop_ioeventfd to start/stop the > >> whole

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-11 Thread Paolo Bonzini
On 11/11/2016 05:09, Alex Williamson wrote: > On Fri, 21 Oct 2016 22:48:10 +0200 > Paolo Bonzini wrote: > >> Override start_ioeventfd and stop_ioeventfd to start/stop the >> whole dataplane logic. This has some positive side effects: >> >> - no need anymore for

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-10 Thread Alex Williamson
On Fri, 21 Oct 2016 22:48:10 +0200 Paolo Bonzini wrote: > Override start_ioeventfd and stop_ioeventfd to start/stop the > whole dataplane logic. This has some positive side effects: > > - no need anymore for virtio_add_queue_aio (i.e. a revert of > commit

[Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-10-21 Thread Paolo Bonzini
Override start_ioeventfd and stop_ioeventfd to start/stop the whole dataplane logic. This has some positive side effects: - no need anymore for virtio_add_queue_aio (i.e. a revert of commit 1c627137c10ee2dcf59e0383ade8a9abfa2d4355) - no need anymore to switch from generic ioeventfd handlers

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-10-19 Thread Cornelia Huck
On Wed, 19 Oct 2016 12:51:37 +0200 Cornelia Huck wrote: > On Mon, 10 Oct 2016 13:53:35 +0200 > Paolo Bonzini wrote: > > > Override start_ioeventfd and stop_ioeventfd to start/stop the > > whole dataplane logic. This has some positive side

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:35 +0200 Paolo Bonzini wrote: > Override start_ioeventfd and stop_ioeventfd to start/stop the > whole dataplane logic. This has some positive side effects: > > - no need anymore for virtio_add_queue_aio (i.e. a revert of > commit

[Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-10-10 Thread Paolo Bonzini
Override start_ioeventfd and stop_ioeventfd to start/stop the whole dataplane logic. This has some positive side effects: - no need anymore for virtio_add_queue_aio (i.e. a revert of commit 1c627137c10ee2dcf59e0383ade8a9abfa2d4355) - no need anymore to switch from generic ioeventfd handlers