Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: > QMP should insult users from underlying platform quirks. We should > translate errnos to appropriate QMP error types. Fair enough. What should it do when the platform returns an errno value that qemu doesn't know about, and wants to pass to the QMP caller? -- Jamie

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-05-10 Thread Markus Armbruster
Anthony Liguori writes: > On 04/21/2010 03:28 AM, Daniel P. Berrange wrote: >> On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: [...] >> Wouldn't it be nicer to return strerror_r() output instead of errno >> names ? >> > > Both are equally wrong :-) > > QMP should insult user

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-05-03 Thread Anthony Liguori
On 04/21/2010 03:28 AM, Daniel P. Berrange wrote: On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: There are error handling functions in QEMU which print errno codes to the user. While it's debatable if this is good from a user perspective, sometimes it's the best you can do

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-22 Thread Luiz Capitulino
On Wed, 21 Apr 2010 19:13:16 +0200 Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Wed, Apr 21, 2010 at 12:12:14PM -0300, Luiz Capitulino wrote: > >> On Wed, 21 Apr 2010 18:42:38 +0400 (MSD) > >> malc wrote: > >> > >> > On Wed, 21 Apr 2010, Kevin Wolf wrote: > >> > > >> > >

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Apr 21, 2010 at 12:12:14PM -0300, Luiz Capitulino wrote: >> On Wed, 21 Apr 2010 18:42:38 +0400 (MSD) >> malc wrote: >> >> > On Wed, 21 Apr 2010, Kevin Wolf wrote: >> > >> > > Am 21.04.2010 10:28, schrieb Daniel P. Berrange: >> > > > On Tue, Apr 20, 2010 a

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread Luiz Capitulino
On Wed, 21 Apr 2010 16:15:58 +0100 "Daniel P. Berrange" wrote: > On Wed, Apr 21, 2010 at 12:12:14PM -0300, Luiz Capitulino wrote: > > On Wed, 21 Apr 2010 18:42:38 +0400 (MSD) > > malc wrote: > > > > > On Wed, 21 Apr 2010, Kevin Wolf wrote: > > > > > > > Am 21.04.2010 10:28, schrieb Daniel P. B

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread Daniel P. Berrange
On Wed, Apr 21, 2010 at 12:12:14PM -0300, Luiz Capitulino wrote: > On Wed, 21 Apr 2010 18:42:38 +0400 (MSD) > malc wrote: > > > On Wed, 21 Apr 2010, Kevin Wolf wrote: > > > > > Am 21.04.2010 10:28, schrieb Daniel P. Berrange: > > > > On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrot

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread Luiz Capitulino
On Wed, 21 Apr 2010 18:42:38 +0400 (MSD) malc wrote: > On Wed, 21 Apr 2010, Kevin Wolf wrote: > > > Am 21.04.2010 10:28, schrieb Daniel P. Berrange: > > > On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: > > >> There are error handling functions in QEMU which print errno codes >

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread malc
On Wed, 21 Apr 2010, Kevin Wolf wrote: > Am 21.04.2010 10:28, schrieb Daniel P. Berrange: > > On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: > >> There are error handling functions in QEMU which print errno codes > >> to the user. While it's debatable if this is good from a user

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread Kevin Wolf
Am 21.04.2010 10:28, schrieb Daniel P. Berrange: > On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: >> There are error handling functions in QEMU which print errno codes >> to the user. While it's debatable if this is good from a user >> perspective, sometimes it's the best you can

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-21 Thread Daniel P. Berrange
On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: > There are error handling functions in QEMU which print errno codes > to the user. While it's debatable if this is good from a user > perspective, sometimes it's the best you can do because it's what > system calls return and this is

[Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-20 Thread Luiz Capitulino
There are error handling functions in QEMU which print errno codes to the user. While it's debatable if this is good from a user perspective, sometimes it's the best you can do because it's what system calls return and this is also useful for debugging. So, we need a way to expose those codes in Q