Re: [Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-26 Thread Eduardo Habkost
On Wed, Sep 26, 2012 at 02:31:25PM -0700, H. Peter Anvin wrote: > On 09/26/2012 01:32 PM, Igor Mammedov wrote: > > + > > +static void x86_cpuid_get_feature(Object *obj, Visitor *v, void *opaque, > > + const char *name, Error **errp) > > +{ > > +X86CPU *cp

Re: [Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-26 Thread H. Peter Anvin
On 09/26/2012 01:32 PM, Igor Mammedov wrote: > + > +static void x86_cpuid_get_feature(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > +X86CPU *cpu = X86_CPU(obj); > +CPUX86State *env = &cpu->env; > +bool value = t

[Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-26 Thread Igor Mammedov
add property accessors for cpuid feature bits defined by *_feature_name arrays. Signed-off-by: Igor Mammedov --- v2: * replaced mask/ffs tricks by plain 'for (bit = 0; bit < 32; bit++)' as suggested by Eduardo Habkost v3: * check if property exists before adding it * rebased on top of

[Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov -- v2: * replaced mask/ffs tricks by plain 'for (bit = 0; bit < 32; bit++)' as suggested by Eduardo Habkost v3: * check if property exists before adding it * rebased on top of "i386: cpu: remove duplicate feature names" http://www.mail-archive.com/