Re: [Qemu-devel] [PATCH 08/10] ppc/xics: allow ICSState to have an offset 0

2019-01-06 Thread David Gibson
On Thu, Jan 03, 2019 at 06:45:25PM +0100, Cédric Le Goater wrote: > On 1/3/19 5:33 AM, David Gibson wrote: > > On Wed, Jan 02, 2019 at 06:57:41AM +0100, Cédric Le Goater wrote: > >> commit 15ed653fa49a ("ppc/xics: An ICS with offset 0 is assumed to be > >> uninitialized") introduced an extra check

Re: [Qemu-devel] [PATCH 08/10] ppc/xics: allow ICSState to have an offset 0

2019-01-03 Thread Cédric Le Goater
On 1/3/19 5:33 AM, David Gibson wrote: > On Wed, Jan 02, 2019 at 06:57:41AM +0100, Cédric Le Goater wrote: >> commit 15ed653fa49a ("ppc/xics: An ICS with offset 0 is assumed to be >> uninitialized") introduced an extra check on the ICS offset which is >> not strictly necessary. > > The commit

Re: [Qemu-devel] [PATCH 08/10] ppc/xics: allow ICSState to have an offset 0

2019-01-02 Thread David Gibson
On Wed, Jan 02, 2019 at 06:57:41AM +0100, Cédric Le Goater wrote: > commit 15ed653fa49a ("ppc/xics: An ICS with offset 0 is assumed to be > uninitialized") introduced an extra check on the ICS offset which is > not strictly necessary. The commit message for that suggests it was added to make pnv

[Qemu-devel] [PATCH 08/10] ppc/xics: allow ICSState to have an offset 0

2019-01-01 Thread Cédric Le Goater
commit 15ed653fa49a ("ppc/xics: An ICS with offset 0 is assumed to be uninitialized") introduced an extra check on the ICS offset which is not strictly necessary. Revert the change to be able to map the XICS IRQ number space on the XIVE IRQ number space. Signed-off-by: Cédric Le Goater ---