Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-27 Thread Alexander Graf
> Am 27.05.2015 um 17:57 schrieb Aurelien Jarno : > >> On 2015-05-27 07:31, Richard Henderson wrote: >>> On 05/26/2015 03:03 PM, Aurelien Jarno wrote: >>> Ok, I understand now. That said I don't see how implementing STFLE will >>> break that. I think it will actually improve things by enabling m

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-27 Thread Aurelien Jarno
On 2015-05-27 07:31, Richard Henderson wrote: > On 05/26/2015 03:03 PM, Aurelien Jarno wrote: > > Ok, I understand now. That said I don't see how implementing STFLE will > > break that. I think it will actually improve things by enabling more > > facilities and thus making the kernel happier (but m

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-27 Thread Alexander Graf
> Am 27.05.2015 um 16:31 schrieb Richard Henderson : > >> On 05/26/2015 03:03 PM, Aurelien Jarno wrote: >> Ok, I understand now. That said I don't see how implementing STFLE will >> break that. I think it will actually improve things by enabling more >> facilities and thus making the kernel happ

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-27 Thread Richard Henderson
On 05/26/2015 03:03 PM, Aurelien Jarno wrote: > Ok, I understand now. That said I don't see how implementing STFLE will > break that. I think it will actually improve things by enabling more > facilities and thus making the kernel happier (but maybe not enough). Somewhat amusingly, by not implemen

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-26 Thread Aurelien Jarno
On 2015-05-26 09:00, Richard Henderson wrote: > On 05/25/2015 11:03 PM, Aurelien Jarno wrote: > > On 2015-05-25 16:08, Richard Henderson wrote: > >> On 05/24/2015 04:47 PM, Aurelien Jarno wrote: > >>> Cc: Alexander Graf > >>> Cc: Richard Henderson > >>> Signed-off-by: Aurelien Jarno > >> > >> Sa

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-26 Thread Richard Henderson
On 05/25/2015 11:03 PM, Aurelien Jarno wrote: > On 2015-05-25 16:08, Richard Henderson wrote: >> On 05/24/2015 04:47 PM, Aurelien Jarno wrote: >>> Cc: Alexander Graf >>> Cc: Richard Henderson >>> Signed-off-by: Aurelien Jarno >> >> Sadly, implementing this breaks current kernels. >> I did this a

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-25 Thread Aurelien Jarno
On 2015-05-25 16:08, Richard Henderson wrote: > On 05/24/2015 04:47 PM, Aurelien Jarno wrote: > >Cc: Alexander Graf > >Cc: Richard Henderson > >Signed-off-by: Aurelien Jarno > > Sadly, implementing this breaks current kernels. > I did this about two years ago and havn't figured > out what to do

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-25 Thread Alexander Graf
On 26.05.15 01:08, Richard Henderson wrote: > On 05/24/2015 04:47 PM, Aurelien Jarno wrote: >> Cc: Alexander Graf >> Cc: Richard Henderson >> Signed-off-by: Aurelien Jarno > > Sadly, implementing this breaks current kernels. > I did this about two years ago and havn't figured > out what to do

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-25 Thread Richard Henderson
On 05/24/2015 04:47 PM, Aurelien Jarno wrote: Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno Sadly, implementing this breaks current kernels. I did this about two years ago and havn't figured out what to do about it. The silly code in head.S doesn't check for just th

[Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-24 Thread Aurelien Jarno
Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/cpu.h | 2 +- target-s390x/helper.h | 1 + target-s390x/insn-data.def | 2 ++ target-s390x/misc_helper.c | 19 +++ target-s390x/translate.c | 7 +++ 5 files changed, 30