Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 16:33:02 +0200 Avi Kivity wrote: > On 01/25/2010 04:29 PM, Markus Armbruster wrote: > > > > I agree with Anthony that async message masking doesn't really affect > > the protocol proper. We could pretend it does so we can let protocol > > capability negotiation (which we need

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Avi Kivity
On 01/25/2010 04:29 PM, Markus Armbruster wrote: I agree with Anthony that async message masking doesn't really affect the protocol proper. We could pretend it does so we can let protocol capability negotiation (which we need anyway) cover it. But I'm certainly fine with keeping it separate.

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 22 Jan 2010 12:05:19 -0600 > Anthony Liguori wrote: > >> On 01/21/2010 03:09 PM, Luiz Capitulino wrote: >> > This commit disables asynchronous messages by default and >> > introduces two new QMP commands: async_msg_enable and >> > async_msg_disable. >> > >> > Ea

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 15:15:59 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Sun, 24 Jan 2010 18:35:14 + > > Jamie Lokier wrote: > > > >> Anthony Liguori wrote: > >> > >I'd like to be able to connect and be sure not to receive any async > >> > >messages, from simple scrip

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Markus Armbruster
Luiz Capitulino writes: > On Sun, 24 Jan 2010 18:35:14 + > Jamie Lokier wrote: > >> Anthony Liguori wrote: >> > >I'd like to be able to connect and be sure not to receive any async >> > >messages, from simple scripts with simple output parsing. >> > >> > You can't have simple output parsing

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Sun, 24 Jan 2010 08:19:53 -0600 Anthony Liguori wrote: > On 01/24/2010 08:17 AM, Avi Kivity wrote: > > On 01/24/2010 04:04 PM, Anthony Liguori wrote: > >>> I agree with that, but we can look at async messages as a baseline > >>> protocol capability (thus no negotiation required), and the new

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Sun, 24 Jan 2010 18:35:14 + Jamie Lokier wrote: > Anthony Liguori wrote: > > >I'd like to be able to connect and be sure not to receive any async > > >messages, from simple scripts with simple output parsing. > > > > You can't have simple output parsing with QMP. You need a full JSON >

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-24 Thread Jamie Lokier
Anthony Liguori wrote: > >I'd like to be able to connect and be sure not to receive any async > >messages, from simple scripts with simple output parsing. > > You can't have simple output parsing with QMP. You need a full JSON > stack. The simplest script would be a python script that uses the

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-24 Thread Anthony Liguori
On 01/24/2010 05:07 AM, Jamie Lokier wrote: Avi Kivity wrote: On 01/22/2010 08:05 PM, Anthony Liguori wrote: On 01/21/2010 03:09 PM, Luiz Capitulino wrote: This commit disables asynchronous messages by default and introduces two new QMP commands: async_msg_enable and async_ms

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-24 Thread Anthony Liguori
On 01/24/2010 08:17 AM, Avi Kivity wrote: On 01/24/2010 04:04 PM, Anthony Liguori wrote: I agree with that, but we can look at async messages as a baseline protocol capability (thus no negotiation required), and the new command only enabled individual messages. To be honest, I don't think th

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-24 Thread Avi Kivity
On 01/24/2010 04:04 PM, Anthony Liguori wrote: I agree with that, but we can look at async messages as a baseline protocol capability (thus no negotiation required), and the new command only enabled individual messages. To be honest, I don't think there's really a need to mask individual mes

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-24 Thread Anthony Liguori
On 01/24/2010 04:34 AM, Avi Kivity wrote: On 01/22/2010 08:05 PM, Anthony Liguori wrote: On 01/21/2010 03:09 PM, Luiz Capitulino wrote: This commit disables asynchronous messages by default and introduces two new QMP commands: async_msg_enable and async_msg_disable. Each QMP Monitor has its ow

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-24 Thread Jamie Lokier
Avi Kivity wrote: > On 01/22/2010 08:05 PM, Anthony Liguori wrote: > >On 01/21/2010 03:09 PM, Luiz Capitulino wrote: > >>This commit disables asynchronous messages by default and > >>introduces two new QMP commands: async_msg_enable and > >>async_msg_disable. > >> > >>Each QMP Monitor has its own s

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-24 Thread Avi Kivity
On 01/22/2010 08:05 PM, Anthony Liguori wrote: On 01/21/2010 03:09 PM, Luiz Capitulino wrote: This commit disables asynchronous messages by default and introduces two new QMP commands: async_msg_enable and async_msg_disable. Each QMP Monitor has its own set of asynchronous messages, so for exam

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-22 Thread Anthony Liguori
On 01/22/2010 02:09 PM, Luiz Capitulino wrote: On Fri, 22 Jan 2010 12:05:19 -0600 Anthony Liguori wrote: On 01/21/2010 03:09 PM, Luiz Capitulino wrote: This commit disables asynchronous messages by default and introduces two new QMP commands: async_msg_enable and async_msg_disable.

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-22 Thread Luiz Capitulino
On Fri, 22 Jan 2010 12:05:19 -0600 Anthony Liguori wrote: > On 01/21/2010 03:09 PM, Luiz Capitulino wrote: > > This commit disables asynchronous messages by default and > > introduces two new QMP commands: async_msg_enable and > > async_msg_disable. > > > > Each QMP Monitor has its own set of asy

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-22 Thread Anthony Liguori
On 01/21/2010 03:09 PM, Luiz Capitulino wrote: This commit disables asynchronous messages by default and introduces two new QMP commands: async_msg_enable and async_msg_disable. Each QMP Monitor has its own set of asynchronous messages, so for example, if QEMU is run with two QMP Monitors async

[Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-21 Thread Luiz Capitulino
This commit disables asynchronous messages by default and introduces two new QMP commands: async_msg_enable and async_msg_disable. Each QMP Monitor has its own set of asynchronous messages, so for example, if QEMU is run with two QMP Monitors async messages setup in one of them doesn't affect the