Re: [Qemu-devel] [PATCH 08/11] target-arm: Pass mmu_idx to get_phys_addr()

2015-01-26 Thread Peter Maydell
On 26 January 2015 at 21:41, Greg Bellows wrote: > The above cases would be more readable if each case had a comment > identifying the corresponding AT instruction. Just faster for reference > purposes. Makes sense; will add them in v2. -- PMM

Re: [Qemu-devel] [PATCH 08/11] target-arm: Pass mmu_idx to get_phys_addr()

2015-01-26 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > Make all the callers of get_phys_addr() pass it the correct > mmu_idx rather than just a simple "is_user" flag. This includes > properly decoding the AT/ATS system instructions; we include the > logic for handling all the opc1/opc2 cases be

[Qemu-devel] [PATCH 08/11] target-arm: Pass mmu_idx to get_phys_addr()

2015-01-23 Thread Peter Maydell
Make all the callers of get_phys_addr() pass it the correct mmu_idx rather than just a simple "is_user" flag. This includes properly decoding the AT/ATS system instructions; we include the logic for handling all the opc1/opc2 cases because we'll need them later for supporting EL2/EL3, even if we do