Re: [Qemu-devel] [PATCH 08/12] cmdline: convert -smp to QemuOpts

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 14:42, Takayuki Konishi ha scritto: -if (!max_cpus) +if (qemu_opts_foreach(qemu_find_opts(smp), smp_init_func, NULL, 1) != 0) { +exit(1); +} +if (!max_cpus) { max_cpus = smp_cpus; - +} Isn't this 'if' block redundant?

Re: [Qemu-devel] [PATCH 08/12] cmdline: convert -smp to QemuOpts

2012-04-13 Thread Takayuki Konishi
On Tue, Mar 20, 2012 at 09:01:34AM +0100, Paolo Bonzini wrote: This introduces a new option group, but it is mostly trivial. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c | 31 + vl.c | 61

[Qemu-devel] [PATCH 08/12] cmdline: convert -smp to QemuOpts

2012-03-20 Thread Paolo Bonzini
This introduces a new option group, but it is mostly trivial. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c | 31 + vl.c | 61 +--- 2 files changed, 58 insertions(+), 34 deletions(-)