Re: [Qemu-devel] [PATCH 08/14] i386: do not compute eflags multiple times consecutively

2012-10-09 Thread Richard Henderson
On 10/06/2012 05:30 AM, Paolo Bonzini wrote: > +static void gen_compute_eflags(DisasContext *s) > { > if (s->cc_op != CC_OP_DYNAMIC) { > gen_op_set_cc_op(s->cc_op); > } > +if (s->cc_op == CC_OP_EFLAGS) { > +return; > } > +gen_helper_cc_compute_all(cpu_tmp2_i

Re: [Qemu-devel] [PATCH 08/14] i386: do not compute eflags multiple times consecutively

2012-10-07 Thread Blue Swirl
On Sat, Oct 6, 2012 at 12:30 PM, Paolo Bonzini wrote: > After calling gen_compute_eflags, leave the computed value in cc_reg_src > and set cc_op to CC_OP_EFLAGS. The next few patches will remove anyway > most calls to gen_compute_eflags. > > As a result of this change it is more natural to remove

[Qemu-devel] [PATCH 08/14] i386: do not compute eflags multiple times consecutively

2012-10-06 Thread Paolo Bonzini
After calling gen_compute_eflags, leave the computed value in cc_reg_src and set cc_op to CC_OP_EFLAGS. The next few patches will remove anyway most calls to gen_compute_eflags. As a result of this change it is more natural to remove the register argument from gen_compute_eflags and change all th