Re: [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors

2015-01-19 Thread Alex Bennée
Peter Maydell writes: > On 19 January 2015 at 09:05, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> Use cpu_*_data instead of the direct *_raw load/store accessors. >> >> I take it this additional level of (macro) redirection is because at >> some point there will be a difference betwee

Re: [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors

2015-01-19 Thread Peter Maydell
On 19 January 2015 at 09:05, Alex Bennée wrote: > > Peter Maydell writes: > >> Use cpu_*_data instead of the direct *_raw load/store accessors. > > I take it this additional level of (macro) redirection is because at > some point there will be a difference between the various cpu accessors? Whic

Re: [Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors

2015-01-19 Thread Alex Bennée
Peter Maydell writes: > Use cpu_*_data instead of the direct *_raw load/store accessors. I take it this additional level of (macro) redirection is because at some point there will be a difference between the various cpu accessors? > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée >

[Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors

2015-01-15 Thread Peter Maydell
Use cpu_*_data instead of the direct *_raw load/store accessors. Signed-off-by: Peter Maydell --- target-mips/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index d619ba4..ea7d95f 100644 --- a/target-mips/op_h