Re: [Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions

2012-01-06 Thread Stefan Hajnoczi
On Mon, Jan 02, 2012 at 06:33:27PM +0200, Avi Kivity wrote: These aren't real regions, since they are never added to the memory hierarchy, but they allow reuse of the dispatch functionality. This would be great as a comment... +extern struct MemoryRegion io_mem_ram; +extern struct

Re: [Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions

2012-01-03 Thread Avi Kivity
On 01/03/2012 12:16 AM, Richard Henderson wrote: On 01/03/2012 03:33 AM, Avi Kivity wrote: -if (is_ram_rom_romd(pd)) { +if (!is_ram_rom_romd(pd)) { Should be merged with a previous patch. Fixed. -- error compiling committee.c: too many arguments to function

[Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions

2012-01-02 Thread Avi Kivity
Convert the fixed-address IO_MEM_RAM, IO_MEM_ROM, IO_MEM_UNASSIGNED, and IO_MEM_NOTDIRTY io handlers to MemoryRegions. These aren't real regions, since they are never added to the memory hierarchy, but they allow reuse of the dispatch functionality. Signed-off-by: Avi Kivity a...@redhat.com ---

Re: [Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions

2012-01-02 Thread Richard Henderson
On 01/03/2012 03:33 AM, Avi Kivity wrote: -if (is_ram_rom_romd(pd)) { +if (!is_ram_rom_romd(pd)) { Should be merged with a previous patch. r~