Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 14:41, Luiz Capitulino ha scritto: >>> > > That DPRINTF() usage is really bizarre, it seems its purpose is to >>> > > report >>> > > an error to the user, but that's a debugging call. >>> > > >>> > > I'd let it there and replace it later with proper tracing code, but >>> > > that's

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-05 Thread Luiz Capitulino
On Fri, 05 Oct 2012 08:25:46 +0200 Paolo Bonzini wrote: > Il 04/10/2012 20:24, Luiz Capitulino ha scritto: > > That DPRINTF() usage is really bizarre, it seems its purpose is to report > > an error to the user, but that's a debugging call. > > > > I'd let it there and replace it later with prope

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 20:24, Luiz Capitulino ha scritto: > That DPRINTF() usage is really bizarre, it seems its purpose is to report > an error to the user, but that's a debugging call. > > I'd let it there and replace it later with proper tracing code, but that's > quite minor for me. Please, at least me

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-04 Thread Luiz Capitulino
On Wed, 3 Oct 2012 16:36:55 +0200 Paolo Bonzini wrote: > Error propagation is already there for socket backends, but it > is (and remains) incomplete because no Error is passed to the > NonBlockingConnectHandler. > > With all protocols understanding Error, the code can be simplified > by removi

[Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-03 Thread Paolo Bonzini
Error propagation is already there for socket backends, but it is (and remains) incomplete because no Error is passed to the NonBlockingConnectHandler. With all protocols understanding Error, the code can be simplified by removing the return value. Before: (qemu) migrate fd: migrate: