Re: [Qemu-devel] [PATCH 08/20] memory: store MemoryRegionSection pointers in phys_map

2012-03-08 Thread Peter Maydell
On 8 March 2012 11:11, Avi Kivity wrote: > On 03/08/2012 12:09 PM, Peter Maydell wrote: >> Is that exec.c comment now out of date? > > For subpage, I think so.  It's still broken for page aligned regions > that have low bits set in their offset: > >  memory_region_init_io(foo, ..., 4097) >  memory

Re: [Qemu-devel] [PATCH 08/20] memory: store MemoryRegionSection pointers in phys_map

2012-03-08 Thread Avi Kivity
On 03/08/2012 12:09 PM, Peter Maydell wrote: > On 8 March 2012 09:50, Avi Kivity wrote: > > On 03/07/2012 09:32 PM, Peter Maydell wrote: > >> Are we running into the "mapping devices at non-page-offsets isn't > >> supported" issue here? > > > > It wasn't supported? > > Well, you used to run into t

Re: [Qemu-devel] [PATCH 08/20] memory: store MemoryRegionSection pointers in phys_map

2012-03-08 Thread Peter Maydell
On 8 March 2012 09:50, Avi Kivity wrote: > On 03/07/2012 09:32 PM, Peter Maydell wrote: >> Are we running into the "mapping devices at non-page-offsets isn't >> supported" issue here? > > It wasn't supported? Well, you used to run into the issue noted in the comment above exec.c:register_subpage(

Re: [Qemu-devel] [PATCH 08/20] memory: store MemoryRegionSection pointers in phys_map

2012-03-08 Thread Avi Kivity
On 03/07/2012 09:32 PM, Peter Maydell wrote: > On 7 March 2012 17:49, Peter Maydell wrote: > > git bisect blames this commit (5312bd8b3) for causing a Linux kernel > > on spitz to produce a bunch of pxa2xx_i2c warnings that weren't > > being emitted before: > > What seems to happen here is that we

Re: [Qemu-devel] [PATCH 08/20] memory: store MemoryRegionSection pointers in phys_map

2012-03-07 Thread Peter Maydell
On 7 March 2012 17:49, Peter Maydell wrote: > git bisect blames this commit (5312bd8b3) for causing a Linux kernel > on spitz to produce a bunch of pxa2xx_i2c warnings that weren't > being emitted before: What seems to happen here is that we register a memory region (this is for the second i2c de

Re: [Qemu-devel] [PATCH 08/20] memory: store MemoryRegionSection pointers in phys_map

2012-03-07 Thread Peter Maydell
On 14 February 2012 09:27, Avi Kivity wrote: > Instead of storing PhysPageDesc, store pointers to MemoryRegionSections. > The various offsets (phys_offset & ~TARGET_PAGE_MASK, > PHYS_OFFSET & TARGET_PAGE_MASK, region_offset) can all be synthesized > from the information in a MemoryRegionSection.  

[Qemu-devel] [PATCH 08/20] memory: store MemoryRegionSection pointers in phys_map

2012-02-14 Thread Avi Kivity
Instead of storing PhysPageDesc, store pointers to MemoryRegionSections. The various offsets (phys_offset & ~TARGET_PAGE_MASK, PHYS_OFFSET & TARGET_PAGE_MASK, region_offset) can all be synthesized from the information in a MemoryRegionSection. Adjust phys_page_find() to synthesize a PhysPageDesc.