[Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-10 Thread Markus Armbruster
device_name[] is can become non-empty only in bdrv_new_named() and bdrv_move_feature_fields(). The latter is used only to undo damage done by bdrv_swap(). The former is called only by blk_new_with_bs(). Therefore, when a BlockDriverState's device_name[] is non-empty, then it's owned by a BlockBac

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-10 Thread Eric Blake
On 09/10/2014 02:13 AM, Markus Armbruster wrote: > device_name[] is can become non-empty only in bdrv_new_named() and s/is // > bdrv_move_feature_fields(). The latter is used only to undo damage > done by bdrv_swap(). The former is called only by blk_new_with_bs(). > Therefore, when a BlockDriv

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : > device_name[] is can become non-empty only in bdrv_new_named() and > bdrv_move_feature_fields(). The latter is used only to undo damage > done by bdrv_swap(). The former is called only by blk_new_with_bs(). > Therefore, whe

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Benoît Canet
The Thursday 11 Sep 2014 à 13:34:33 (+0200), Benoît Canet wrote : > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : > > device_name[] is can become non-empty only in bdrv_new_named() and > > bdrv_move_feature_fields(). The latter is used only to undo damage > > done by bdrv

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Eric Blake
On 09/11/2014 05:34 AM, Benoît Canet wrote: > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : >> device_name[] is can become non-empty only in bdrv_new_named() and >> bdrv_move_feature_fields(). The latter is used only to undo damage >> done by bdrv_swap(). The former is c

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Benoît Canet
The Thursday 11 Sep 2014 à 07:00:41 (-0600), Eric Blake wrote : > On 09/11/2014 05:34 AM, Benoît Canet wrote: > > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : > >> device_name[] is can become non-empty only in bdrv_new_named() and > >> bdrv_move_feature_fields(). The lat

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Markus Armbruster
Eric Blake writes: > On 09/10/2014 02:13 AM, Markus Armbruster wrote: >> device_name[] is can become non-empty only in bdrv_new_named() and > > s/is // Fixing, thanks! >> bdrv_move_feature_fields(). The latter is used only to undo damage >> done by bdrv_swap(). The former is called only by bl

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : >> device_name[] is can become non-empty only in bdrv_new_named() and >> bdrv_move_feature_fields(). The latter is used only to undo damage >> done by bdrv_swap(). The former is called only by blk_new

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Thursday 11 Sep 2014 à 07:00:41 (-0600), Eric Blake wrote : >> On 09/11/2014 05:34 AM, Benoît Canet wrote: >> > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : >> >> device_name[] is can become non-empty only in bdrv_new_named() and >> >> bdrv_mo