[Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-07-06 Thread Markus Armbruster
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, except it was put into block.c. Device-specific functionality should be kept in device code, not the block layer. Move it to hw/hd-geometry.c, and make stylistic changes required to keep checkpatch.pl happy. Signed-off-by: Markus

Re: [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-07-04 Thread Kevin Wolf
Am 03.07.2012 20:40, schrieb Blue Swirl: > On Sat, Jun 30, 2012 at 5:50 AM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster >>> wrote: Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, except it was put into bloc

Re: [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-07-03 Thread Blue Swirl
On Sat, Jun 30, 2012 at 5:50 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: >>> Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, >>> except it was put into block.c. Device-specific functionality should >>> be kep

Re: [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-06-29 Thread Markus Armbruster
Blue Swirl writes: > On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: >> Commit f3d54fc4 factored it out of hw/ide.c for reuse.  Sensible, >> except it was put into block.c.  Device-specific functionality should >> be kept in device code, not the block layer.  Move it to >> hw/hd-geomet

Re: [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: > Commit f3d54fc4 factored it out of hw/ide.c for reuse.  Sensible, > except it was put into block.c.  Device-specific functionality should > be kept in device code, not the block layer.  Move it to > hw/hd-geometry.c, and make stylistic ch

[Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-06-29 Thread Markus Armbruster
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, except it was put into block.c. Device-specific functionality should be kept in device code, not the block layer. Move it to hw/hd-geometry.c, and make stylistic changes required to keep checkpatch.pl happy. Signed-off-by: Markus