Re: [Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish Hello world

2015-06-07 Thread Chen Gang
After thinking of again, for me, I still prefer to keep gen_cntlz() and others, the reason is below: - gen_* (include gen_cntlz) are used in multiple areas, and most gen_* are not single statement. For each gen_*, printing insns is easy (and may be helpful). - decode* is for switch

Re: [Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish Hello world

2015-06-02 Thread Peter Maydell
On 30 May 2015 at 22:18, Chen Gang xili_gchen_5...@hotmail.com wrote: Generate related tcg instructions, and qemu tilegx can finish running Hello world. The elf64 binary can be static or shared. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- target-tilegx/translate.c | 2787

Re: [Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish Hello world

2015-06-02 Thread Chen Gang
On 6/3/15 01:54, Peter Maydell wrote: On 30 May 2015 at 22:18, Chen Gang xili_gchen_5...@hotmail.com wrote: Generate related tcg instructions, and qemu tilegx can finish running Hello world. The elf64 binary can be static or shared. Signed-off-by: Chen Gang gang.chen.5...@gmail.com ---

Re: [Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish Hello world

2015-06-02 Thread Chen Gang
On 6/3/15 00:32, Richard Henderson wrote: On 06/01/2015 01:54 PM, Chen Gang wrote: Further, the TILEGX_R_COUNT restriction is also incorrect. True, you don't actually implement the top 7 special registers, but that doesn't matter, you should still be incrementing them. We did not

Re: [Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish Hello world

2015-06-02 Thread Richard Henderson
On 06/01/2015 01:54 PM, Chen Gang wrote: Further, the TILEGX_R_COUNT restriction is also incorrect. True, you don't actually implement the top 7 special registers, but that doesn't matter, you should still be incrementing them. We did not implement them, so can not increment them, either.

Re: [Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish Hello world

2015-06-01 Thread Richard Henderson
First, what happened to the decoding skeleton patch? You seem to have merged it with patch 9 here. That said, see the bottom of this message. On 05/30/2015 02:18 PM, Chen Gang wrote: +/* mfspr can be only in X1 pipe, so it doesn't need to be bufferd */ +static void gen_mfspr(struct

Re: [Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish Hello world

2015-06-01 Thread Chen Gang
Firstly, thank you very much for your valuable work and quick response. On 6/2/15 02:40, Richard Henderson wrote: First, what happened to the decoding skeleton patch? You seem to have merged it with patch 9 here. That said, see the bottom of this message. Yes, I merged them together. For

[Qemu-devel] [PATCH 09/10 v11] target-tilegx: Generate tcg instructions to finish Hello world

2015-05-30 Thread Chen Gang
Generate related tcg instructions, and qemu tilegx can finish running Hello world. The elf64 binary can be static or shared. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- target-tilegx/translate.c | 2787 + 1 file changed, 2787 insertions(+)